Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1729723006: Fix clang compile failure due to -fsanitize-coverage=1 (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix clang compile failure due to -fsanitize-coverage=1 Took options from GN's flag value. TBR=hans BUG=589841 Committed: https://crrev.com/e9efb69c0c2c35554f8e5204d8b34322b41148d0 Cr-Commit-Position: refs/heads/master@{#377680}

Patch Set 1 #

Patch Set 2 : fix case when flag isn't set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729723006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729723006/1
4 years, 10 months ago (2016-02-25 19:42:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/150227) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-25 19:51:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729723006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729723006/20001
4 years, 10 months ago (2016-02-25 20:12:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 21:59:26 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 22:00:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9efb69c0c2c35554f8e5204d8b34322b41148d0
Cr-Commit-Position: refs/heads/master@{#377680}

Powered by Google App Engine
This is Rietveld 408576698