Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1729683007: Remove unused blink::WebStorageArea::memoryBytesUsedByCache(). (Closed)

Created:
4 years, 10 months ago by jam
Modified:
4 years, 9 months ago
Reviewers:
michaeln
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused blink::WebStorageArea::memoryBytesUsedByCache(). BUG=586194 Committed: https://crrev.com/e7636b85b2a1db449d52e14c2e1c8c4611ae28b1 Cr-Commit-Position: refs/heads/master@{#378293}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M content/renderer/dom_storage/dom_storage_cached_area.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/dom_storage/dom_storage_cached_area.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/dom_storage/local_storage_area.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/dom_storage/local_storage_area.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/dom_storage/webstoragearea_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/dom_storage/webstoragearea_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageArea.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageArea.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebStorageArea.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
jam
4 years, 10 months ago (2016-02-27 01:11:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729683007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729683007/1
4 years, 9 months ago (2016-02-29 18:56:30 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/137875) ios_rel_device_ninja on ...
4 years, 9 months ago (2016-02-29 18:59:30 UTC) #6
michaeln
lgtm
4 years, 9 months ago (2016-02-29 19:52:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729683007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729683007/20001
4 years, 9 months ago (2016-02-29 20:28:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/123340)
4 years, 9 months ago (2016-02-29 20:58:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729683007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729683007/20001
4 years, 9 months ago (2016-02-29 20:59:37 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 22:34:13 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 22:35:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7636b85b2a1db449d52e14c2e1c8c4611ae28b1
Cr-Commit-Position: refs/heads/master@{#378293}

Powered by Google App Engine
This is Rietveld 408576698