third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp - Issue 1729683002: Remove old-style constraints from Chrome internals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

Issue 1729683002: Remove old-style constraints from Chrome internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Complete the interface change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp ('k') | third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

index 5d168bb7dc149efc95b5d3cfedff3b573e3c776f..b595c8ab5d3f8d1fac06f25f21c51eb248a9fb79 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

@@ -593,13 +593,13 @@ void RTCPeerConnection::updateIce(ExecutionContext* context, const Dictionary& r

return;

MediaErrorState mediaErrorState;

- WebMediaConstraints constraints = MediaConstraintsImpl::create(context, mediaConstraints, mediaErrorState);

if (mediaErrorState.hadException()) {

mediaErrorState.raiseException(exceptionState);

return;

}

- bool valid = m_peerHandler->updateICE(configuration, constraints);

+ // Constraints are ignored.

+ bool valid = m_peerHandler->updateICE(configuration);

if (!valid)

exceptionState.throwDOMException(SyntaxError, "Could not update the ICE Agent with the given configuration.");

}