Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2076)

Unified Diff: content/renderer/media/user_media_client_impl.cc

Issue 1729683002: Remove old-style constraints from Chrome internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Complete the interface change Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/user_media_client_impl.cc
diff --git a/content/renderer/media/user_media_client_impl.cc b/content/renderer/media/user_media_client_impl.cc
index ac75749e256e3e71ad261354b2674b114e8125d3..12a9529746ccd543341416119017065b14640fa1 100644
--- a/content/renderer/media/user_media_client_impl.cc
+++ b/content/renderer/media/user_media_client_impl.cc
@@ -21,6 +21,7 @@
#include "content/public/renderer/render_frame.h"
#include "content/renderer/media/media_stream.h"
#include "content/renderer/media/media_stream_audio_source.h"
+#include "content/renderer/media/media_stream_constraints_util.h"
#include "content/renderer/media/media_stream_dispatcher.h"
#include "content/renderer/media/media_stream_video_capturer_source.h"
#include "content/renderer/media/media_stream_video_track.h"
@@ -217,37 +218,25 @@ void UserMediaClientImpl::requestUserMedia(
<< ", video=" << (controls.video.requested) << " ], "
<< security_origin.spec() << ")";
- blink::WebString audio_device_id;
- bool mandatory_audio = false;
+ std::string audio_device_id;
if (!user_media_request.isNull() && user_media_request.audio()) {
- mandatory_audio =
- user_media_request.audioConstraints().getMandatoryConstraintValue(
- base::UTF8ToUTF16(kMediaStreamSourceInfoId), audio_device_id);
- if (!mandatory_audio) {
- user_media_request.audioConstraints().getOptionalConstraintValue(
- base::UTF8ToUTF16(kMediaStreamSourceInfoId), audio_device_id);
- }
+ GetConstraintValueAsString(user_media_request.audioConstraints(),
+ &blink::WebMediaTrackConstraintSet::deviceId,
+ &audio_device_id);
}
- blink::WebString video_device_id;
- bool mandatory_video = false;
+ std::string video_device_id;
if (!user_media_request.isNull() && user_media_request.video()) {
- mandatory_video =
- user_media_request.videoConstraints().getMandatoryConstraintValue(
- base::UTF8ToUTF16(kMediaStreamSourceInfoId), video_device_id);
- if (!mandatory_video) {
- user_media_request.videoConstraints().getOptionalConstraintValue(
- base::UTF8ToUTF16(kMediaStreamSourceInfoId), video_device_id);
- }
+ GetConstraintValueAsString(user_media_request.videoConstraints(),
+ &blink::WebMediaTrackConstraintSet::deviceId,
+ &video_device_id);
}
WebRtcLogMessage(base::StringPrintf(
"MSI::requestUserMedia. request_id=%d"
- ", audio source id=%s mandatory= %s "
- ", video source id=%s mandatory= %s",
- request_id, audio_device_id.utf8().c_str(),
- mandatory_audio ? "true" : "false", video_device_id.utf8().c_str(),
- mandatory_video ? "true" : "false"));
+ ", audio source id=%s"
+ ", video source id=%s",
+ request_id, audio_device_id.c_str(), video_device_id.c_str()));
user_media_requests_.push_back(
new UserMediaRequestInfo(request_id, user_media_request,

Powered by Google App Engine
This is Rietveld 408576698