Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1729653002: Ensure Array.prototype.indexOf returns +0 rather than -0 (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
jugglinmike, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure Array.prototype.indexOf returns +0 rather than -0 A recent ES2016 draft spec clarification indicates that, if -0 is passed into Array.prototype.indexOf or Array.prototype.lastIndexOf as the starting index, and the result is found at index 0, then +0 rather than -0 should be returned. This patch ensures that V8 has that result, which is consistent with what some other browsers return. The patch allows a couple test262 tests to pass. R=adamk LOG=Y Committed: https://crrev.com/8798ef2d1c254c2d1898a6dd56bf98ddfd60cce5 Cr-Commit-Position: refs/heads/master@{#34229}

Patch Set 1 #

Patch Set 2 : Enable test262 tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/js/array.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729653002/1
4 years, 10 months ago (2016-02-23 21:19:08 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15890)
4 years, 10 months ago (2016-02-23 21:31:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729653002/20001
4 years, 10 months ago (2016-02-23 23:00:15 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 23:21:29 UTC) #9
Dan Ehrenberg
4 years, 10 months ago (2016-02-23 23:22:22 UTC) #10
adamk
lgtm
4 years, 10 months ago (2016-02-23 23:28:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729653002/20001
4 years, 10 months ago (2016-02-23 23:30:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 23:33:05 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 23:33:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8798ef2d1c254c2d1898a6dd56bf98ddfd60cce5
Cr-Commit-Position: refs/heads/master@{#34229}

Powered by Google App Engine
This is Rietveld 408576698