Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1729613002: PPC: [fullcodegen] Implement operand stack depth tracking. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [fullcodegen] Implement operand stack depth tracking. Port 38915ed71c179276a1368ea8442bf88f66f50a4c Original commit message: This implements a mechanism to track the exact depth of the operand stack in full-codegen for every sub-expression visitation. So far we only tracked the depth at statement level, but not at expression level. With the introduction of do-expressions it will be possible to construct local control flow (i.e. break, continue and friends) that target labels at an arbitrary operand stack depth, making this tracking a prerequisite for full do-expression support. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4755, v8:4488 LOG=n Committed: https://crrev.com/b3de78c191420d0c9c9883c2065e0185f9591594 Cr-Commit-Position: refs/heads/master@{#34227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -108 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 78 chunks +152 lines, -108 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-23 19:38:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729613002/1
4 years, 10 months ago (2016-02-23 19:38:46 UTC) #3
Michael Starzinger
LGTM. Thanks!
4 years, 10 months ago (2016-02-23 19:42:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 20:02:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729613002/1
4 years, 10 months ago (2016-02-23 20:06:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 20:08:12 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 20:09:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3de78c191420d0c9c9883c2065e0185f9591594
Cr-Commit-Position: refs/heads/master@{#34227}

Powered by Google App Engine
This is Rietveld 408576698