Issue 17296003: Remove import process workarounds from ExtensionService

Issue 17296003: Remove import process workarounds from ExtensionService (Closed)

Created:
7 years, 6 months ago by elijahtaylor1

Modified:
7 years, 6 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, playmobil1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove import process workarounds from ExtensionService BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207391

Patch Set 3 : feedback, more workarounds removed #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -69 lines)			Patch
M	chrome/browser/extensions/extension_service.h	View	1 2	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1 2	3 chunks	+12 lines, -52 lines	1 comment	Download
M	chrome/browser/extensions/extension_system.cc	View	1 2	1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

https://codereview.chromium.org/17296003/diff/11001/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (left): https://codereview.chromium.org/17296003/diff/11001/chrome/browser/extensions/extension_service.cc#oldcode569 chrome/browser/extensions/extension_service.cc:569: RegisterForImportFinished(); I think we can get rid of this ...

7 years, 6 months ago (2013-06-19 18:32:22 UTC) #2

elijahtaylor1

7 years, 6 months ago (2013-06-19 19:04:01 UTC) #4

asargent_no_longer_on_chrome

+playmobil as FYI lgtm https://codereview.chromium.org/17296003/diff/27001/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (left): https://codereview.chromium.org/17296003/diff/27001/chrome/browser/extensions/extension_service.cc#oldcode474 chrome/browser/extensions/extension_service.cc:474: scoped_timer("Startup.SlowStartupExtensionServiceInitAfterImport"); FYI, the folks working ...

7 years, 6 months ago (2013-06-19 19:39:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/17296003/27001

7 years, 6 months ago (2013-06-20 01:53:02 UTC) #6

Message was sent while issue was closed.

Change committed as 207391

Expand Messages | Collapse Messages