Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing files Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h b/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h
index 7388eca4f0f6aacf62f9ccbb00ab4be7b0a5b691..b2f89abd19376b062d59e8852af562272aefdd43 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h
+++ b/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h
@@ -31,38 +31,35 @@
#ifndef RTCVoidRequestImpl_h
#define RTCVoidRequestImpl_h
-#include "core/dom/ActiveDOMObject.h"
+#include "core/dom/ExceptionCode.h"
#include "platform/heap/Handle.h"
#include "platform/mediastream/RTCVoidRequest.h"
namespace blink {
-class RTCErrorCallback;
class RTCPeerConnection;
+class RTCPeerConnectionErrorCallback;
class VoidCallback;
-class RTCVoidRequestImpl final : public RTCVoidRequest, public ActiveDOMObject {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCVoidRequestImpl);
+class RTCVoidRequestImpl final : public RTCVoidRequest {
public:
- static RTCVoidRequestImpl* create(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTCErrorCallback*);
+ static RTCVoidRequestImpl* create(RTCPeerConnection*, VoidCallback*, RTCPeerConnectionErrorCallback*, ExceptionCode);
~RTCVoidRequestImpl() override;
// RTCVoidRequest
void requestSucceeded() override;
void requestFailed(const String& error) override;
- // ActiveDOMObject
- void stop() override;
-
DECLARE_VIRTUAL_TRACE();
private:
- RTCVoidRequestImpl(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTCErrorCallback*);
+ RTCVoidRequestImpl(RTCPeerConnection*, VoidCallback*, RTCPeerConnectionErrorCallback*, ExceptionCode);
void clear();
Member<VoidCallback> m_successCallback;
- Member<RTCErrorCallback> m_errorCallback;
+ Member<RTCPeerConnectionErrorCallback> m_errorCallback;
+ ExceptionCode m_exceptionCode;
Member<RTCPeerConnection> m_requester;
};

Powered by Google App Engine
This is Rietveld 408576698