Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing files Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
index 2e5b07324fa239155729110f4ab463136fa3ed43..00edf75038304468e56234a338ff8fbf6bc49055 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
+++ b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
@@ -31,7 +31,6 @@
#ifndef RTCSessionDescriptionRequestImpl_h
#define RTCSessionDescriptionRequestImpl_h
-#include "core/dom/ActiveDOMObject.h"
#include "platform/heap/Handle.h"
#include "platform/mediastream/RTCSessionDescriptionRequest.h"
#include "wtf/PassOwnPtr.h"
@@ -39,32 +38,28 @@
namespace blink {
-class RTCErrorCallback;
class RTCPeerConnection;
+class RTCPeerConnectionErrorCallback;
class RTCSessionDescriptionCallback;
class WebRTCSessionDescription;
-class RTCSessionDescriptionRequestImpl final : public RTCSessionDescriptionRequest, public ActiveDOMObject {
philipj_slow 2016/02/24 08:14:03 Is the ActiveDOMObject change made possible by thi
Guido Urdaneta 2016/02/24 12:42:10 Reverted.
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCSessionDescriptionRequestImpl);
+class RTCSessionDescriptionRequestImpl final : public RTCSessionDescriptionRequest {
public:
- static RTCSessionDescriptionRequestImpl* create(ExecutionContext*, RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCErrorCallback*);
+ static RTCSessionDescriptionRequestImpl* create(RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCPeerConnectionErrorCallback*);
~RTCSessionDescriptionRequestImpl() override;
void requestSucceeded(const WebRTCSessionDescription&) override;
void requestFailed(const String& error) override;
- // ActiveDOMObject
- void stop() override;
-
DECLARE_VIRTUAL_TRACE();
private:
- RTCSessionDescriptionRequestImpl(ExecutionContext*, RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCErrorCallback*);
+ RTCSessionDescriptionRequestImpl(RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCPeerConnectionErrorCallback*);
void clear();
Member<RTCSessionDescriptionCallback> m_successCallback;
- Member<RTCErrorCallback> m_errorCallback;
+ Member<RTCPeerConnectionErrorCallback> m_errorCallback;
Member<RTCPeerConnection> m_requester;
};

Powered by Google App Engine
This is Rietveld 408576698