Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp b/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp
index 2618c965e9a2c08025143219f7c1390431b44d66..c9b754b4b2a964648728dbf22e483bc1f1932850 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp
@@ -6,19 +6,19 @@
#include "bindings/core/v8/ScriptPromiseResolver.h"
#include "core/dom/DOMException.h"
+#include "core/dom/ExceptionCode.h"
#include "modules/mediastream/RTCPeerConnection.h"
namespace blink {
-RTCVoidRequestPromiseImpl* RTCVoidRequestPromiseImpl::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver, ExceptionCode exceptionCode)
+RTCVoidRequestPromiseImpl* RTCVoidRequestPromiseImpl::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver)
{
- return new RTCVoidRequestPromiseImpl(requester, resolver, exceptionCode);
+ return new RTCVoidRequestPromiseImpl(requester, resolver);
}
-RTCVoidRequestPromiseImpl::RTCVoidRequestPromiseImpl(RTCPeerConnection* requester, ScriptPromiseResolver* resolver, ExceptionCode exceptionCode)
+RTCVoidRequestPromiseImpl::RTCVoidRequestPromiseImpl(RTCPeerConnection* requester, ScriptPromiseResolver* resolver)
: m_requester(requester)
, m_resolver(resolver)
- , m_exceptionCode(exceptionCode)
{
ASSERT(m_requester);
ASSERT(m_resolver);
@@ -44,7 +44,8 @@ void RTCVoidRequestPromiseImpl::requestSucceeded()
void RTCVoidRequestPromiseImpl::requestFailed(const String& error)
{
if (m_requester && m_requester->shouldFireDefaultCallbacks()) {
- m_resolver->reject(DOMException::create(m_exceptionCode, error));
+ // TODO(guidou): The error code should come from the content layer. See crbug.com/589455
+ m_resolver->reject(DOMException::create(OperationError, error));
} else {
// This is needed to have the resolver release its internal resources
// while leaving the associated promise pending as specified.

Powered by Google App Engine
This is Rietveld 408576698