third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h - Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnectionErrorCallback.idl ('k') | third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

index 2e5b07324fa239155729110f4ab463136fa3ed43..86d534e2527d93a4dab0e195016a83ef31106e1a 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

+++ b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

@@ -39,15 +39,15 @@

namespace blink {

-class RTCErrorCallback;

class RTCPeerConnection;

+class RTCPeerConnectionErrorCallback;

class RTCSessionDescriptionCallback;

class WebRTCSessionDescription;

class RTCSessionDescriptionRequestImpl final : public RTCSessionDescriptionRequest, public ActiveDOMObject {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCSessionDescriptionRequestImpl);

public:

- static RTCSessionDescriptionRequestImpl* create(ExecutionContext*, RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCErrorCallback*);

+ static RTCSessionDescriptionRequestImpl* create(ExecutionContext*, RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCPeerConnectionErrorCallback*);

~RTCSessionDescriptionRequestImpl() override;

void requestSucceeded(const WebRTCSessionDescription&) override;

@@ -59,12 +59,12 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- RTCSessionDescriptionRequestImpl(ExecutionContext*, RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCErrorCallback*);

+ RTCSessionDescriptionRequestImpl(ExecutionContext*, RTCPeerConnection*, RTCSessionDescriptionCallback*, RTCPeerConnectionErrorCallback*);

void clear();

Member<RTCSessionDescriptionCallback> m_successCallback;

- Member<RTCErrorCallback> m_errorCallback;

+ Member<RTCPeerConnectionErrorCallback> m_errorCallback;

Member<RTCPeerConnection> m_requester;

};