third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl - Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback.

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnectionErrorCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

index 4bf0f5d1f08390087c7091851218ec52639e264a..8938088df476b4e0f7689ce1a310af3399f6d1e4 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

@@ -59,7 +59,6 @@ enum RTCIceConnectionState {

// TODO(guidou): Many types are of the wrong type in this interface:

// * Dictionary -> specific dictionary types like RTCConfiguration

-// * RTCErrorCallback -> RTCPeerConnectionErrorCallback

// * VoidCallback -> VoidFunction

[

GarbageCollected,

@@ -99,13 +98,13 @@ enum RTCIceConnectionState {

// https://w3c.github.io/webrtc-pc/#legacy-interface-extensions

// These methods return or will be changed to return Promise<void> because

// having Promise-based versions requires that all overloads return Promises.

- [CallWith=ExecutionContext, RaisesException] void createOffer(RTCSessionDescriptionCallback successCallback, RTCErrorCallback failureCallback, optional Dictionary rtcOfferOptions);

+ [CallWith=ExecutionContext, RaisesException] void createOffer(RTCSessionDescriptionCallback successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Dictionary rtcOfferOptions);

// TODO(guidou): There should be no mediaConstraints argument.

- [CallWith=ExecutionContext, RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);

- [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescription description, VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);

+ [CallWith=ExecutionContext, RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Dictionary mediaConstraints);

+ [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescription description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);

// TODO(guidou): The failureCallback argument should be non-optional.

- [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescription description, VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);

- [CallWith=ScriptState] Promise<void> addIceCandidate(RTCIceCandidate candidate, VoidCallback successCallback, RTCErrorCallback failureCallback);

+ [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescription description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);

+ [CallWith=ScriptState] Promise<void> addIceCandidate(RTCIceCandidate candidate, VoidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback);

// TODO(guidou): The selector argument should the first (nullable,

// non-optional) argument, and there should be a third failureCallback

// argument.