Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html
diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html
index ef99d222d1980b65735554ad0bf050f59b1b8ed2..dff8fd217b2b3a3e8d2c5db6ae4c3ca86585fa20 100644
--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html
+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html
@@ -33,8 +33,9 @@ function unexpectedCallback()
function expectedTypeError(error)
{
- shouldBe(error.name, "TypeError")
- testPassed("expectedTypeError was called.")
+ window.error = error;
+ shouldBe('error.name', '"TypeError"');
+ testPassed("expectedTypeError was called.");
}
function onIceChange1()
@@ -54,12 +55,13 @@ function testExecutionOrderClosedConnection()
var localPeerConnection = new webkitRTCPeerConnection(null, null);
localPeerConnection.close();
var counter = 0;
- events = [];
+ window.events = [];
Promise.resolve().then(_ => events[counter++] = 1);
var iceCandidate = new RTCIceCandidate({candidate:"nano nano"});
- localPeerConnection.addIceCandidate(iceCandidate, unexpectedCallback, (error) => {
+ localPeerConnection.addIceCandidate(iceCandidate, unexpectedCallback, error => {
window.error = error;
- shouldBe('error', '"The RTCPeerConnection\'s signalingState is \'closed\'."');
+ shouldBe('error.name', '"InvalidStateError"');
+ shouldBe('error.toString()', '"InvalidStateError: The RTCPeerConnection\'s signalingState is \'closed\'."');
events[counter++] = 2;
});
Promise.resolve().then(_ => {

Powered by Google App Engine
This is Rietveld 408576698