Mojo: Make MessageInTransit more opaque.

mojo/system/channel.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/system/channel.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
@@ skipping 175 matching lines @@
       // tested (TODO(vtl)).
       DLOG(ERROR) << "This should not happen under normal operation.";
       return;
     }
     endpoint_info = it->second;
   }
 
   // We need to duplicate the message, because |EnqueueMessage()| will take
   // ownership of it.
   // TODO(vtl): Need to enforce limits on message size and handle count.
-  MessageInTransit* own_message = MessageInTransit::Create(
-      message.type(), message.subtype(), message.bytes(), message.num_bytes(),
-      message.num_handles());
+  MessageInTransit* own_message = message.Clone();
   std::vector<DispatcherTransport> transports(message.num_handles());
   // TODO(vtl): Create dispatchers for handles.
   // TODO(vtl): It's bad that the current API will create equivalent dispatchers
   // for the freshly-created ones, which is totally redundant. Make a version of
   // |EnqueueMessage()| that passes ownership.
   if (endpoint_info.message_pipe->EnqueueMessage(
           MessagePipe::GetPeerPort(endpoint_info.port), own_message,
           message.num_handles() ? &transports : NULL) != MOJO_RESULT_OK) {
     HandleLocalError(base::StringPrintf(
         "Failed to enqueue message to local destination ID %u",
@@ skipping 13 matching lines @@
   LOG(WARNING) << error_message;
 }
 
 void Channel::HandleLocalError(const base::StringPiece& error_message) {
   // TODO(vtl): Is this how we really want to handle this?
   LOG(FATAL) << error_message;
 }
 
 }  // namespace system
 }  // namespace mojo