Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1729493002: [wasm] I added I64Eq to the Int64Lowering. (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int64-lowering-xor
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] I added I64Eq to the Int64Lowering. (a EQ b) is lowered to ((low(a) XOR low(b)) OR (high(a) XOR high(b))) EQ 0 R=titzer@chromium.org Committed: https://crrev.com/18d9da0dcfb2a93259c3dacfce2c409956027cf1 Cr-Commit-Position: refs/heads/master@{#34249}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add a todo. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M src/compiler/int64-lowering.cc View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 10 months ago (2016-02-23 15:23:49 UTC) #1
titzer
lgtm https://codereview.chromium.org/1729493002/diff/1/src/compiler/int64-lowering.cc File src/compiler/int64-lowering.cc (right): https://codereview.chromium.org/1729493002/diff/1/src/compiler/int64-lowering.cc#newcode301 src/compiler/int64-lowering.cc:301: Node* replacement = graph()->NewNode( Can you add a ...
4 years, 10 months ago (2016-02-23 15:49:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729493002/40001
4 years, 10 months ago (2016-02-24 11:57:00 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-24 12:09:24 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 12:09:42 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/18d9da0dcfb2a93259c3dacfce2c409956027cf1
Cr-Commit-Position: refs/heads/master@{#34249}

Powered by Google App Engine
This is Rietveld 408576698