Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/tests/skimage_self_test.py

Issue 17294006: skimage: if --readPath points at an empty dir, create an empty expectations file (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/tests/skimage_self_test.py
===================================================================
--- tools/tests/skimage_self_test.py (revision 9641)
+++ tools/tests/skimage_self_test.py (working copy)
@@ -9,6 +9,7 @@
import os
import subprocess
import sys
+import tempfile
class BinaryNotFoundException(Exception):
def __str__ (self):
@@ -70,6 +71,26 @@
# TODO(scroggo): Add a test that compares expectations and image files that
# are known to NOT match, and make sure it returns an error.
+ # Generate an expectations file from an empty directory.
+ empty_dir = tempfile.mkdtemp()
+ expectations_path = os.path.join(file_dir, "skimage", "output-actual",
+ "empty-dir", "expectations.json")
+ subprocess.check_call([skimage_binary, "--readPath", empty_dir,
+ "--createExpectationsPath", expectations_path])
+ golden_expectations = os.path.join(file_dir, "skimage", "output-expected",
+ "empty-dir", "expectations.json")
+ DieIfFilesMismatch(expected=golden_expectations, actual=expectations_path)
+ os.rmdir(empty_dir)
+
+ # Generate an expectations file from a nonexistent directory.
+ expectations_path = os.path.join(file_dir, "skimage", "output-actual",
+ "nonexistent-dir", "expectations.json")
+ subprocess.check_call([skimage_binary, "--readPath", "/nonexistent/dir",
+ "--createExpectationsPath", expectations_path])
+ golden_expectations = os.path.join(file_dir, "skimage", "output-expected",
+ "nonexistent-dir", "expectations.json")
+ DieIfFilesMismatch(expected=golden_expectations, actual=expectations_path)
+
# Done with all tests.
print "Self tests succeeded!"

Powered by Google App Engine
This is Rietveld 408576698