Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: tools/skimage_main.cpp

Issue 17294006: skimage: if --readPath points at an empty dir, create an empty expectations file (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/skimage_main.cpp
===================================================================
--- tools/skimage_main.cpp (revision 9641)
+++ tools/skimage_main.cpp (working copy)
@@ -515,7 +515,8 @@
decodeFileAndWrite(fullname.c_str(), outDirPtr);
} while (iter.next(&filename));
} else {
- decodeFileAndWrite(FLAGS_readPath[i], outDirPtr);
+ // FLAGS_readPath[i] is an empty or nonexistent directory,
scroggo 2013/06/19 15:34:09 I am okay with the spirit of this change, but this
epoger 2013/06/19 15:54:15 Yup. It is handy that --readPath can take either
+ // so do nothing.
}
}

Powered by Google App Engine
This is Rietveld 408576698