src/unbound-queue.h - Issue 17294004: Fix data race in v8::internal::UnboundQueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/unbound-queue.h

Issue 17294004: Fix data race in v8::internal::UnboundQueue (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Dmitry's comments addressed: added NoBarrier_Load Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/unbound-queue.h

diff --git a/src/unbound-queue.h b/src/unbound-queue.h

index 59a426b7fedf72c822a6d8d4aaf1ee2aa75b3213..429e3c673e5e9d0e316656ad9bd32e0a5696d366 100644

--- a/src/unbound-queue.h

+++ b/src/unbound-queue.h

@@ -46,10 +46,10 @@ class UnboundQueue BASE_EMBEDDED {

inline UnboundQueue();

inline ~UnboundQueue();

- INLINE(void Dequeue(Record* rec));

+ INLINE(bool Dequeue(Record* rec));

INLINE(void Enqueue(const Record& rec));

- INLINE(bool IsEmpty()) { return divider_ == last_; }

- INLINE(Record* Peek());

+ INLINE(bool IsEmpty() const);

+ INLINE(Record* Peek() const);

private:

INLINE(void DeleteFirst());

« no previous file with comments | « src/optimizing-compiler-thread.cc ('k') | src/unbound-queue-inl.h » ('j') | no next file with comments »