Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/unbound-queue.h

Issue 17294004: Fix data race in v8::internal::UnboundQueue (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/optimizing-compiler-thread.cc ('k') | src/unbound-queue-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/unbound-queue.h
diff --git a/src/unbound-queue.h b/src/unbound-queue.h
index 59a426b7fedf72c822a6d8d4aaf1ee2aa75b3213..7b3964430e33a1ec8c54407047eac49f0721eea9 100644
--- a/src/unbound-queue.h
+++ b/src/unbound-queue.h
@@ -46,7 +46,7 @@ class UnboundQueue BASE_EMBEDDED {
inline UnboundQueue();
inline ~UnboundQueue();
- INLINE(void Dequeue(Record* rec));
+ INLINE(bool Dequeue(Record* rec));
INLINE(void Enqueue(const Record& rec));
INLINE(bool IsEmpty()) { return divider_ == last_; }
Dmitry Vyukov 2013/06/17 19:51:57 this must use NoBarrier_Load's
yurys 2013/06/18 08:01:00 Done.
INLINE(Record* Peek());
« no previous file with comments | « src/optimizing-compiler-thread.cc ('k') | src/unbound-queue-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698