Tune helper context buffer sizes

content/browser/renderer_host/image_transport_factory_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/image_transport_factory_android.h"
 
 #include "base/memory/singleton.h"
 #include "content/browser/gpu/browser_gpu_channel_host_factory.h"
 #include "content/browser/renderer_host/compositor_impl_android.h"
 #include "content/common/gpu/client/gl_helper.h"
 #include "content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h"
 #include "content/common/gpu/gpu_process_launch_causes.h"
 #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
 #include "third_party/khronos/GLES2/gl2.h"
+#include "ui/gfx/android/device_display_info.h"
 #include "webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h"
 
 namespace content {
 
 namespace {
 
 using webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl;
 
 static ImageTransportFactoryAndroid* g_factory = NULL;
 
@@ skipping 64 matching lines @@
 CmdBufferImageTransportFactory::CmdBufferImageTransportFactory() {
   WebKit::WebGraphicsContext3D::Attributes attrs;
   attrs.shareResources = true;
   GpuChannelHostFactory* factory = BrowserGpuChannelHostFactory::instance();
   GURL url("chrome://gpu/ImageTransportFactoryAndroid");
   base::WeakPtr<WebGraphicsContext3DSwapBuffersClient> swap_client;
   context_.reset(new WebGraphicsContext3DCommandBufferImpl(0, // offscreen
                                                            url,
                                                            factory,
                                                            swap_client));
-  context_->InitializeWithDefaultBufferSizes(
+  static size_t kBitsPerByte = 8;

[no sievers, 2013/06/17 19:06:35]

nit: const

[kaanb, 2013/06/18 11:20:03]

Done.

+  gfx::DeviceDisplayInfo display_info;
+  size_t full_screen_texture_size_in_bytes =
+      display_info.GetDisplayHeight() *
+      display_info.GetDisplayWidth() *
+      display_info.GetBitsPerPixel() / kBitsPerByte;

[no sievers, 2013/06/17 19:06:35]

I don't think we need to look at the display bpp here, since the transfer buffer
is used for texture uploads and readbacks where we choose the format. So just
hardcode to 4?

[kaanb, 2013/06/18 11:20:03]

Done.

+  context_->Initialize(
       attrs,
       false,
-      CAUSE_FOR_GPU_LAUNCH_WEBGRAPHICSCONTEXT3DCOMMANDBUFFERIMPL_INITIALIZE);
+      CAUSE_FOR_GPU_LAUNCH_WEBGRAPHICSCONTEXT3DCOMMANDBUFFERIMPL_INITIALIZE,
+      64 * 1024,  // command buffer size
+      std::min(full_screen_texture_size_in_bytes,
+               kDefaultStartTransferBufferSize),
+      kDefaultMinTransferBufferSize,
+      std::min(3 * full_screen_texture_size_in_bytes,
+               kDefaultMaxTransferBufferSize));

[no sievers, 2013/06/17 19:06:35]

These values seem to not cap anything if you assume 480*800 as the lowest res we
want to optimize for (start 1.5m, max. 4.6m).

[kaanb, 2013/06/18 11:20:03]

Yes, we're not capping the starting size but we're capping the max size. The
default is 16MB.

 }
 
 CmdBufferImageTransportFactory::~CmdBufferImageTransportFactory() {
 }
 
 uint32_t CmdBufferImageTransportFactory::InsertSyncPoint() {
   if (!context_->makeContextCurrent()) {
     LOG(ERROR) << "Failed to make helper context current.";
     return 0;
   }
@@ skipping 66 matching lines @@
   return g_factory;
 }
 
 ImageTransportFactoryAndroid::ImageTransportFactoryAndroid() {
 }
 
 ImageTransportFactoryAndroid::~ImageTransportFactoryAndroid() {
 }
 
 } // namespace content