Chromium Code Reviews| Index: content/browser/browser_plugin/browser_plugin_guest.cc |
| diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc |
| index d0f1049b8df1423ba0c6748801580955f68ac945..612347c83c535b82d3c0c929b93460eb184d3de4 100644 |
| --- a/content/browser/browser_plugin/browser_plugin_guest.cc |
| +++ b/content/browser/browser_plugin/browser_plugin_guest.cc |
| @@ -749,6 +749,9 @@ void BrowserPluginGuest::OnWillAttachComplete( |
| // If a RenderView has already been created for this new window, then we need |
| // to initialize the browser-side state now so that the RenderFrameHostManager |
| // does not create a new RenderView on navigation. |
| + // TODO(wjmaclean): this pathway doesn't seem to ever get hit when using |
| + // cross-process-frames ... should it be removed? Or am I just missing a |
| + // use case? |
| if (!use_cross_process_frames && has_render_view_) { |
| // This will trigger a callback to RenderViewReady after a round-trip IPC. |
| static_cast<RenderViewHostImpl*>(GetWebContents()->GetRenderViewHost()) |
| @@ -788,7 +791,7 @@ void BrowserPluginGuest::OnDetach(int browser_plugin_instance_id) { |
| // it's attached again. |
| attached_ = false; |
| - RenderWidgetHostViewGuest* rwhv = static_cast<RenderWidgetHostViewGuest*>( |
| + RenderWidgetHostViewBase* rwhv = static_cast<RenderWidgetHostViewGuest*>( |
|
kenrb
2016/02/25 00:58:04
I don't understand this change. Can the guest WebC
wjmaclean
2016/02/25 12:23:02
I changed one side of the cast, but not the other
|
| web_contents()->GetRenderWidgetHostView()); |
| // If the guest is terminated, our host may already be gone. |
| if (rwhv) |