Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1729373003: Implement touch events for site-isolation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use positioned iframe in test to simplify event targeting. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 71f9bb47db810bc5856a6146e069fd5d91aeeda0..8c4f9db408c4d34299f5f513774f89ef338b387b 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -891,8 +891,10 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, ReloadEmbedder) {
}
IN_PROC_BROWSER_TEST_P(WebViewTest, AcceptTouchEvents) {
- // TODO(lfg): Fix touch events for OOPIF-based webview.
- // https://crbug.com/581892
+ // This test only makes sense for non-OOPIF WebView, since with
+ // UseCrossProcessFramesForGuests() events are routed directly to the
+ // guest, so the embedder does not need to know about the installation of
+ // touch handlers.
if (content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests())
return;
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698