Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3887)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1729373003: Implement touch events for site-isolation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 54645635bdece3348d4b6cb0b61e17c47d225d96..b04a839558d7f5a80ab435a55b844b8b7c7ef583 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -891,8 +891,10 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, ReloadEmbedder) {
}
IN_PROC_BROWSER_TEST_P(WebViewTest, AcceptTouchEvents) {
- // TODO(lfg): Fix touch events for OOPIF-based webview.
- // https://crbug.com/581892
+ // This test only makes sense for non-OOPIF WebView, since with
+ // UseCrossProcessFramesForGuests() events are routed directly to the
+ // guest, so the embedder does not need to know about the installation of
+ // touch handlers.
if (content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests())
return;

Powered by Google App Engine
This is Rietveld 408576698