Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.h

Issue 1729373002: PlzNavigate: fix DevToolsProtocolTest.CrossSitePauseInBeforeUnload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + addressed comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.h
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h
index f190d4cf862a202f095c284e6bed6bbb09351fe7..24d05358ad98f48176a741f57abd25cf9f596cbe 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.h
+++ b/content/browser/devtools/render_frame_devtools_agent_host.h
@@ -55,12 +55,15 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
RenderFrameHost* current);
static void OnBeforeNavigation(RenderFrameHost* current,
RenderFrameHost* pending);
+ static void OnBeforeNavigation(NavigationHandle* navigation_handle);
void SynchronousSwapCompositorFrame(
const cc::CompositorFrameMetadata& frame_metadata);
bool HasRenderFrameHost(RenderFrameHost* host);
+ FrameTreeNode* frame_tree_node() { return frame_tree_node_; }
+
// DevTooolsAgentHost overrides.
void DisconnectWebContents() override;
void ConnectWebContents(WebContents* web_contents) override;
@@ -90,7 +93,6 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
void InspectElement(int x, int y) override;
// WebContentsObserver overrides.
- void DidStartNavigation(NavigationHandle* navigation_handle) override;
void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override;
void DidFinishNavigation(NavigationHandle* navigation_handle) override;
void RenderFrameHostChanged(RenderFrameHost* old_host,
@@ -116,6 +118,7 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
void AboutToNavigateRenderFrame(RenderFrameHost* old_host,
RenderFrameHost* new_host);
+ void AboutToNavigate(NavigationHandle* navigation_handle);
void DispatchBufferedProtocolMessagesIfNecessary();
@@ -137,8 +140,6 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
void OnRequestNewWindow(RenderFrameHost* sender, int new_routing_id);
void DestroyOnRenderFrameGone();
- bool MatchesMyTreeNode(NavigationHandle* navigation_handle);
-
class FrameHostHolder;
scoped_ptr<FrameHostHolder> current_;
@@ -170,9 +171,8 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
// Handle that caused the setting of pending_.
NavigationHandle* pending_handle_;
- // Navigation counter and queue for buffering protocol messages during a
- // navigation.
- int in_navigation_;
+ // List of handles currently navigating.
+ std::set<NavigationHandle*> navigating_handles_;
// <call_id> -> <session_id, message>
std::map<int, std::pair<int, std::string>>

Powered by Google App Engine
This is Rietveld 408576698