[Android] Port Scroller.java to C++ and use for fling animations

webkit/child/fling_animator_impl_android.h

Index: webkit/child/fling_animator_impl_android.h
diff --git a/webkit/child/fling_animator_impl_android.h b/webkit/child/fling_animator_impl_android.h
index c4703677874680940a0dffcb4e57975f1f1a02e9..aa00dc6b5eaa55ab6c3edcaf1036d108f87938da 100644
--- a/webkit/child/fling_animator_impl_android.h
+++ b/webkit/child/fling_animator_impl_android.h
@@ -5,11 +5,10 @@
 #ifndef WEBKIT_CHILD_FLING_ANIMATOR_IMPL_ANDROID_H_
 #define WEBKIT_CHILD_FLING_ANIMATOR_IMPL_ANDROID_H_
 
-#include "base/android/scoped_java_ref.h"
+#include "base/memory/scoped_ptr.h"
 #include "third_party/WebKit/public/platform/WebFloatPoint.h"
 #include "third_party/WebKit/public/platform/WebGestureCurve.h"
 #include "third_party/WebKit/public/platform/WebSize.h"
-#include "ui/gfx/point.h"
 #include "ui/gfx/point_f.h"
 #include "webkit/child/webkit_child_export.h"
 
@@ -17,6 +16,10 @@ namespace blink {
 class WebGestureCurveTarget;
 }
 
+namespace gfx {
+class Scroller;
+}
+
 namespace webkit_glue {
 
 class WEBKIT_CHILD_EXPORT FlingAnimatorImpl : public blink::WebGestureCurve {
@@ -28,31 +31,21 @@ class WEBKIT_CHILD_EXPORT FlingAnimatorImpl : public blink::WebGestureCurve {
       const blink::WebFloatPoint& velocity,
       const blink::WebSize&);
 
-  virtual bool apply(double time,
-                     blink::WebGestureCurveTarget* target);
-
-  static bool RegisterJni(JNIEnv*);
+  virtual bool apply(double time, blink::WebGestureCurveTarget* target);
 
  private:
   void StartFling(const gfx::PointF& velocity);
-  // Returns true if the animation is not yet finished.
-  bool UpdatePosition();
-  gfx::Point GetCurrentPosition();
-  float GetCurrentVelocity();
-  virtual void CancelFling();
+  void CancelFling();
 
   bool is_active_;
 
-  // Java OverScroller instance and methods.
-  base::android::ScopedJavaGlobalRef<jobject> java_scroller_;
+  scoped_ptr<gfx::Scroller> scroller_;

[jamesr, 2014/02/21 23:41:13]

why heap allocate this object? it's always constructed, seems like it'd be
better to have it be a member instead of a pointer

[jdduke (slow), 2014/02/22 00:06:57]

No reason at all, done.

 
-  gfx::Point last_position_;
-  gfx::PointF last_velocity_;
-  double last_time_;
+  gfx::PointF last_position_;
 
   DISALLOW_COPY_AND_ASSIGN(FlingAnimatorImpl);
 };
 
-} // namespace webkit_glue
+}  // namespace webkit_glue
 
-#endif // WEBKIT_CHILD_FLING_ANIMATOR_IMPL_ANDROID_H_
+#endif  // WEBKIT_CHILD_FLING_ANIMATOR_IMPL_ANDROID_H_