Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1729313002: Remove ".orig" files and add a check to presubmit (Closed)

Created:
4 years, 10 months ago by petrcermak
Modified:
4 years, 10 months ago
Reviewers:
sullivan, nduca
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Remove ".orig" files and add a check to presubmit This patch: 1. removes all existing ".orig" files in the Catapult repository: third_party/Paste/paste/urlmap.py.orig third_party/Paste/paste/util/template.py.orig 2. adds a presubmit check that ensures no ".orig" files can be checked in in the future. Rationale: ".orig" files are backup files generated by git. This check already exists in the Chromium repository: https://code.google.com/p/chromium/codesearch#chromium/src/PRESUBMIT.py&l=1744 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1fda6fc076c0ba7d4e3ac8a6f5168835d7d06cc0

Patch Set 1 #

Patch Set 2 : Generate a single presubmit error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1025 lines) Patch
M PRESUBMIT.py View 2 chunks +2 lines, -0 lines 0 comments Download
A catapult_build/repo_checks.py View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/Paste/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
D third_party/Paste/paste/urlmap.py.orig View 1 chunk +0 lines, -263 lines 0 comments Download
D third_party/Paste/paste/util/template.py.orig View 1 chunk +0 lines, -762 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
petrcermak
Hi, Please review this small patch. Thanks, Petr
4 years, 10 months ago (2016-02-24 14:28:58 UTC) #2
nduca
nice, thanks! lgtm
4 years, 10 months ago (2016-02-24 17:13:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729313002/20001
4 years, 10 months ago (2016-02-24 17:48:55 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 18:15:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698