chrome/browser/resources/md_history/side_bar.html - Issue 1729263005: MD History: Display synced tabs history.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_history/side_bar.html

Issue 1729263005: MD History: Display synced tabs history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mdh_shared_styles

Patch Set: add tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_history/history.js ('K') | « chrome/browser/resources/md_history/shared_style.html ('k') | chrome/browser/resources/md_history/side_bar.js » ('j') | chrome/browser/resources/md_history/synced_device_card.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">

	4

	5 <dom-module id="side-bar">
	tsergeant 2016/03/01 03:58:23 I think we should keep all of these element names I think we should keep all of these element names 'namespaced' as 'history-side-bar' etc. Downloads and setting both do this, although they make it a little more terse by leaving the prefix out of filenames. calamity 2016/03/08 02:46:51 Done. Show quoted text On 2016/03/01 03:58:23, tsergeant wrote: > I think we should keep all of these element names 'namespaced' as > 'history-side-bar' etc. > > Downloads and setting both do this, although they make it a little more terse by > leaving the prefix out of filenames. Done.
	6 <template>

	7 <style>

	8 #navigation-menu {

	9 padding-top: 5px;

	10 width: 200px;

	11 }

	12

	13 .nav-button {

	14 @apply(--layout-center);

	15 @apply(--layout-horizontal);

	16 cursor: pointer;

	17 height: 48px;

	18 position: relative;

	19 }

	20

	21 p {

	22 -webkit-padding-start: 25px;

	23 -webkit-user-select: none;

	24 color: #333;

	25 font-size: 14px;

	26 font-weight: 500;

	27 margin: 0;

	28 }

	29

	30 .selected p {

	31 color: rgb(68, 119, 221);

	32 }

	33 </style>

	34 <div id="navigation-menu">
	tsergeant 2016/03/01 03:58:23 Can you get rid of #navigation-menu and just use : Can you get rid of #navigation-menu and just use :host instead? Secondly, do you know if there's a reason why paper-menu wasn't used here? Seems like it would add some nice things like keyboard control. (md-settings uses a paper-menu with styling kinda similar to what we're doing) calamity 2016/03/08 02:46:51 Done. Show quoted text On 2016/03/01 03:58:23, tsergeant wrote: > Can you get rid of #navigation-menu and just use :host instead? > > Secondly, do you know if there's a reason why paper-menu wasn't used here? Seems > like it would add some nice things like keyboard control. > > (md-settings uses a paper-menu with styling kinda similar to what we're doing) Done.
	35 <div on-tap="changeDisplay" id="history-button"

	36 class="nav-button selected">

	37 <p i18n-content="title"></p>

	38 <paper-ripple></paper-ripple>

	39 </div>

	40 <div on-tap="changeDisplay" id="synced-tabs-button" class="nav-button">

	41 <p>Open Tabs</p>
	tsergeant 2016/03/01 03:58:23 i18n this string i18n this string calamity 2016/03/08 02:46:51 Done. Show quoted text On 2016/03/01 03:58:23, tsergeant wrote: > i18n this string Done.
	42 <paper-ripple></paper-ripple>

	43 </div>

	44 </div>

	45 </template>

	46 <script src="chrome://history/side_bar.js"></script>

	47 </dom-module>

OLD	NEW