Issue 172923002: [polymer] fix editor hints -- query/queryAll and unused imports

Issue 172923002: [polymer] fix editor hints -- query/queryAll and unused imports (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly

Modified:
6 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[polymer] fix editor hints -- query/queryAll and unused imports R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=32825

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -54 lines)			Patch
M	pkg/polymer/lib/deploy.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/polymer/lib/src/build/build_filter.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/lib/src/build/code_extractor.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/lib/src/build/linter.dart	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	pkg/polymer/lib/src/build/runner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/lib/src/build/script_compactor.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/polymer/lib/src/instance.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/lib/src/loader.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/attr_deserialize_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/attr_mustache_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/polymer/test/bind_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/build/linter_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/polymer/test/build/static_clean_test.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/polymer/test/custom_event_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/polymer/test/entered_view_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/polymer/test/event_handlers_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/event_path_declarative_test.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/polymer/test/event_path_test.dart	View		2 chunks	+11 lines, -11 lines	0 comments	Download
M	pkg/polymer/test/events_test.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	pkg/polymer/test/instance_attrs_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/prop_attr_bind_reflection_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/polymer/test/prop_attr_reflection_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/polymer/test/property_change_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/polymer/test/publish_attributes_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/publish_inherited_properties_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/take_attributes_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/template_distribute_dynamic_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer/test/unbind_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

:) LGTM https://codereview.chromium.org/172923002/diff/1/pkg/polymer/test/build/static_clean_test.dart File pkg/polymer/test/build/static_clean_test.dart (right): https://codereview.chromium.org/172923002/diff/1/pkg/polymer/test/build/static_clean_test.dart#newcode11 pkg/polymer/test/build/static_clean_test.dart:11: print(build); // suppress unused import warning. fyi ...

6 years, 10 months ago (2014-02-19 21:31:27 UTC) #2

Jennifer Messerly

https://codereview.chromium.org/172923002/diff/1/pkg/polymer/test/build/static_clean_test.dart File pkg/polymer/test/build/static_clean_test.dart (right): https://codereview.chromium.org/172923002/diff/1/pkg/polymer/test/build/static_clean_test.dart#newcode11 pkg/polymer/test/build/static_clean_test.dart:11: print(build); // suppress unused import warning. On 2014/02/19 21:31:27, ...

6 years, 10 months ago (2014-02-19 21:40:51 UTC) #3

Jennifer Messerly

6 years, 10 months ago (2014-02-19 21:41:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32825 (presubmit successful).

Expand Messages | Collapse Messages