Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html

Issue 172913002: Add hide/show for stack frame variables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html
index e030bf0c8470e437838353c96b14da86fc1e43a4..6eeb18cfd10925f1b548574d6c56be703da91553 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html
@@ -25,24 +25,25 @@
<div class="col-md-9">
<function-ref app="{{ app }}" ref="{{ frame['function'] }}"></function-ref>
( <script-ref app="{{ app }}" ref="{{ frame['script'] }}" line="{{ frame['line'] }}">
- </script-ref> )
+ </script-ref> ) {
+ <a on-click="{{ toggleExpand }}">...</a>
+
+ <template if="{{ expanded }}">
+ <table class="memberList">
+ <tr template repeat="{{ v in frame['vars'] }}">
+ <td class="member">{{ v['name']}}</td>
+ <td class="member">
+ <instance-ref app="{{ app }}" ref="{{ v['value'] }}"></instance-ref>
+ </td>
+ </tr>
+ </table>
+ </template>
+ }
+
</div>
<div class="col-md-1"></div>
</div>
- <div class="row">
- <div class="col-md-3"></div>
- <div class="col-md-9">
- <table class="memberList">
- <tr template repeat="{{ v in frame['vars'] }}">
- <td class="member">{{ v['name']}}</td>
- <td class="member">
- <instance-ref app="{{ app }}" ref="{{ v['value'] }}"></instance-ref>
- </td>
- </tr>
- </table>
- </div>
- </div>
</template>
<script type="application/dart" src="stack_frame.dart"></script>
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698