Issue 17291013: Revert "[Android] Support building standalone APK in component build"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17291013: Revert "[Android] Support building standalone APK in component build" (Closed)

Created:
7 years, 6 months ago by gone

Modified:
7 years, 6 months ago

Reviewers:
cjhopman, aurimas (slooooooooow)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "[Android] Support building standalone APK in component build" This breaks the Android component build. This reverts commit 125e64a9eb6406446fb864aea9fa887521f19616. >> [Android] Support building standalone APK in component build >> >> Many people's workflows assume that they can install the APK created in >> out/Debug/apks. With the component build that APK is actually an >> "incomplete" APK that cannot be manually installed (or rather causes >> obscure errors when manually installed). >> >> This change does two things. First, it moves the "incomplete" APK >> output to out/Debug/<package_name>/<ApkName>.apk. This should prevent >> accidental installs of the "incomplete" APK. Second, it introduces an >> option (create_standalone_apk) that when doing a component build, if >> set, will merge the shared libraries into the "incomplete" APK to >> create a standalone APK. This standalone APK will be created in >> out/Debug/apks/. >> >> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207345 >> >> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207516 BUG= R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207587

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -205 lines)			Patch
D	build/android/create_standalone_apk_action.gypi	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	build/android/developer_recommended_flags.gypi	View	1 chunk	+2 lines, -7 lines	0 comments	Download
D	build/android/finalize_apk_action.gypi	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	build/android/gyp/create_standalone_apk.py	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	build/common.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/java_apk.gypi	View	7 chunks	+27 lines, -49 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gone

7 years, 6 months ago (2013-06-20 21:42:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r207587 (presubmit successful).

Expand Messages | Collapse Messages