Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1637)

Unified Diff: tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart

Issue 17290005: Update inferrer test after r24138. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart
diff --git a/tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart b/tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart
index 400c0f8d354d06c846db593c5c144231cf9ef772..0d015589a6c4e17679d175644461c3bff122a20e 100644
--- a/tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart
+++ b/tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart
@@ -108,7 +108,7 @@ main() {
}
checkReturn('test1', typesInferrer.intType);
- checkReturn('test2', typesInferrer.dynamicType);
+ checkReturn('test2', typesInferrer.dynamicType.nonNullable());
checkReturn('test3', typesInferrer.intType);
checkReturn('test4', typesInferrer.mapType);
checkReturn('test5', typesInferrer.dynamicType.nonNullable());
@@ -118,17 +118,13 @@ main() {
compiler.runCompiler(uri);
typesInferrer = compiler.typesTask.typesInferrer;
- checkReturn('test1', typesInferrer.dynamicType);
+ checkReturn('test1', typesInferrer.dynamicType.nonNullable());
checkReturn('test2', typesInferrer.mapType);
checkReturn('test3', typesInferrer.mapType);
checkReturn('test4', typesInferrer.mapType);
checkReturn('test5', typesInferrer.mapType);
- // TODO(ngeoffray): The reason for nullablity is because the
- // inferrer thinks Object.noSuchMethod return null. Once we track
- // aborting control flow in the analysis, we won't get the nullable
- // anymore.
- checkReturn('test6', typesInferrer.numType.nullable());
+ checkReturn('test6', typesInferrer.numType);
checkReturn('test7', typesInferrer.intType);
checkReturn('test8', typesInferrer.intType);
checkReturn('test9', typesInferrer.intType);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698