Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1728953003: X87: [fullcodegen] Implement operand stack depth tracking. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [fullcodegen] Implement operand stack depth tracking. port 38915ed71c179276a1368ea8442bf88f66f50a4c (r34211) original commit message: This implements a mechanism to track the exact depth of the operand stack in full-codegen for every sub-expression visitation. So far we only tracked the depth at statement level, but not at expression level. With the introduction of do-expressions it will be possible to construct local control flow (i.e. break, continue and friends) that target labels at an arbitrary operand stack depth, making this tracking a prerequisite for full do-expression support. BUG= Committed: https://crrev.com/9458a6e4d88094b2ca8a31f3b2ec1b67916bd282 Cr-Commit-Position: refs/heads/master@{#34231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -121 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 76 chunks +151 lines, -121 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-24 02:13:00 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-24 03:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728953003/1
4 years, 10 months ago (2016-02-24 03:12:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 03:33:23 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 03:34:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9458a6e4d88094b2ca8a31f3b2ec1b67916bd282
Cr-Commit-Position: refs/heads/master@{#34231}

Powered by Google App Engine
This is Rietveld 408576698