Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 17289005: Add support using EXPECT_EQ with NullableString16 objects. (Closed)

Created:
7 years, 6 months ago by darin (slow to review)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Add support using EXPECT_EQ with NullableString16 objects. Change the default constructor to set is_null_ to true. This makes NullableString16 act more like a WebKit::WebString, which is really the reason NullableString16 exists at all. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206805

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M base/strings/nullable_string16.h View 3 chunks +15 lines, -1 line 0 comments Download
A base/strings/nullable_string16.cc View 1 chunk +17 lines, -0 lines 1 comment Download
A base/strings/nullable_string16_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
darin (slow to review)
I'm just carving part of https://codereview.chromium.org/16335022/ out into a separate CL. It was really handy ...
7 years, 6 months ago (2013-06-17 18:44:34 UTC) #1
darin (slow to review)
7 years, 6 months ago (2013-06-17 18:44:47 UTC) #2
brettw
lgtm
7 years, 6 months ago (2013-06-17 20:30:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/17289005/1
7 years, 6 months ago (2013-06-17 20:49:56 UTC) #4
darin (slow to review)
Committed patchset #1 manually as r206805 (presubmit successful).
7 years, 6 months ago (2013-06-17 21:37:54 UTC) #5
Avi (use Gerrit)
https://codereview.chromium.org/17289005/diff/1/base/strings/nullable_string16.cc File base/strings/nullable_string16.cc (right): https://codereview.chromium.org/17289005/diff/1/base/strings/nullable_string16.cc#newcode5 base/strings/nullable_string16.cc:5: #include "base/nullable_string16.h" I'll eventually fix this up, but this ...
7 years, 6 months ago (2013-06-18 21:02:42 UTC) #6
darin (slow to review)
7 years, 6 months ago (2013-06-18 21:35:19 UTC) #7
Message was sent while issue was closed.
On 2013/06/18 21:02:42, Avi wrote:
>
https://codereview.chromium.org/17289005/diff/1/base/strings/nullable_string1...
> File base/strings/nullable_string16.cc (right):
> 
>
https://codereview.chromium.org/17289005/diff/1/base/strings/nullable_string1...
> base/strings/nullable_string16.cc:5: #include "base/nullable_string16.h"
> I'll eventually fix this up, but this should be
base/strings/nullable_string16.h
> :)

Oops, I had originally developed the CL before you moved nullable_string16.h
into base/strings/

Powered by Google App Engine
This is Rietveld 408576698