Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1728893002: Remove standalone/noopt_test. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove standalone/noopt_test. -- The dart binary doesn't understand --noopt anymore. -- Noopt coverage now comes from the whole test suite being running against dart_noopt. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/71b0f6d9c4d3abec214d8303f3a6df9272cb040b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
D tests/standalone/noopt_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M tests/standalone/standalone.status View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 10 months ago (2016-02-24 00:43:50 UTC) #2
Florian Schneider
Lgtm
4 years, 10 months ago (2016-02-24 16:36:45 UTC) #3
rmacnak
4 years, 10 months ago (2016-02-24 17:32:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71b0f6d9c4d3abec214d8303f3a6df9272cb040b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698