Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1728823002: Intl: Use private symbols to memoize bound functions (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Intl: Use private symbols to memoize bound functions The Intl object used to keep around functions which are bound to the receiver and memoized in the object (as required by the ECMA-402 spec) in ordinary properties with names like __boundformat__. This patch instead stores those methods in private symbol properties, so they are not exposed to users. A search in GitHub didn't find any uses of __boundformat__ (whereas the same search found plenty of usages of other V8 Intl features), so I think this should be fine in terms of web compatibility. BUG=v8:3785 R=adamk LOG=Y Committed: https://crrev.com/a59f62fcd8082736d91d8d10912a6ecf18590b44 Cr-Commit-Position: refs/heads/master@{#34230}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -22 lines) Patch
M src/js/i18n.js View 1 1 chunk +11 lines, -22 lines 0 comments Download
M test/intl/number-format/format-is-bound.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728823002/1
4 years, 10 months ago (2016-02-23 22:31:30 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 22:53:18 UTC) #4
Dan Ehrenberg
4 years, 10 months ago (2016-02-23 23:12:31 UTC) #5
adamk
lgtm https://codereview.chromium.org/1728823002/diff/1/src/js/i18n.js File src/js/i18n.js (right): https://codereview.chromium.org/1728823002/diff/1/src/js/i18n.js#newcode230 src/js/i18n.js:230: // funciton macro. Typo nit: s/funciton/function/
4 years, 10 months ago (2016-02-23 23:14:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728823002/20001
4 years, 10 months ago (2016-02-23 23:22:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 00:04:41 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 00:05:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a59f62fcd8082736d91d8d10912a6ecf18590b44
Cr-Commit-Position: refs/heads/master@{#34230}

Powered by Google App Engine
This is Rietveld 408576698