Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 17288018: Re-land 16025005 with fix for statics perf issue (Closed)

Created:
7 years, 6 months ago by Chris Rogers
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Re-land 16025005 with tiny fix for statics perf issue 16025005 had review from: palmer@chromium.org, piman@chromium.org, scherkus@chromium.org BUG=163795 TBR=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1170 lines, -1 line) Patch
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +5 lines, -1 line 0 comments Download
A content/browser/renderer_host/media/midi_host.h View 1 chunk +62 lines, -0 lines 0 comments Download
A content/browser/renderer_host/media/midi_host.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/media/midi_messages.h View 1 chunk +46 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
A content/renderer/media/midi_message_filter.h View 1 chunk +116 lines, -0 lines 0 comments Download
A content/renderer/media/midi_message_filter.cc View 1 chunk +199 lines, -0 lines 0 comments Download
A content/renderer/media/renderer_webmidiaccessor_impl.h View 1 chunk +41 lines, -0 lines 0 comments Download
A content/renderer/media/renderer_webmidiaccessor_impl.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/media.gyp View 3 chunks +8 lines, -0 lines 0 comments Download
A media/midi/midi_manager.h View 1 chunk +109 lines, -0 lines 0 comments Download
A media/midi/midi_manager.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A media/midi/midi_manager_mac.h View 1 chunk +69 lines, -0 lines 0 comments Download
A media/midi/midi_manager_mac.cc View 1 chunk +205 lines, -0 lines 0 comments Download
A media/midi/midi_port_info.h View 1 chunk +36 lines, -0 lines 0 comments Download
A media/midi/midi_port_info.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Rogers
only difference from 16025005 is to avoid #include <iostream> in midi_port_info.cc which caused statics perf ...
7 years, 6 months ago (2013-06-22 03:58:10 UTC) #1
Chris Rogers
Committed patchset #1 manually as r208003.
7 years, 6 months ago (2013-06-22 04:03:10 UTC) #2
Avi (use Gerrit)
7 years, 6 months ago (2013-06-24 22:23:40 UTC) #3
Message was sent while issue was closed.
I am getting build errors on my Mac:

../../media/midi/midi_manager_mac.cc:26:20: error: implicit conversion of NULL
constant to 'MIDIClientRef' (aka 'unsigned int') [-Werror,-Wnull-conversion]
    : midi_client_(NULL),
                  ~^~~~
                   0
../../media/midi/midi_manager_mac.cc:27:23: error: implicit conversion of NULL
constant to 'MIDIPortRef' (aka 'unsigned int') [-Werror,-Wnull-conversion]
      coremidi_input_(NULL),
                     ~^~~~
                      0
../../media/midi/midi_manager_mac.cc:28:24: error: implicit conversion of NULL
constant to 'MIDIPortRef' (aka 'unsigned int') [-Werror,-Wnull-conversion]
      coremidi_output_(NULL),
                      ~^~~~
                       0
../../media/midi/midi_manager_mac.cc:37:18: error: implicit conversion of NULL
constant to 'MIDIClientRef' (aka 'unsigned int') [-Werror,-Wnull-conversion]
  midi_client_ = NULL;
               ~ ^~~~
                 0
../../media/midi/midi_manager_mac.cc:47:21: error: implicit conversion of NULL
constant to 'MIDIPortRef' (aka 'unsigned int') [-Werror,-Wnull-conversion]
  coremidi_input_ = NULL;
                  ~ ^~~~
                    0
../../media/midi/midi_manager_mac.cc:86:5: error: no matching function for call
to 'MIDIPortConnectSource'
    MIDIPortConnectSource(coremidi_input_, src, src);
    ^~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode5-DP.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:1289:1:
note: candidate function not viable: no known conversion from 'MIDIEndpointRef'
(aka 'unsigned int') to 'void *' for 3rd argument; take the address of the
argument with &
MIDIPortConnectSource(  MIDIPortRef             port, 
^
../../media/midi/midi_manager_mac.cc:113:28: error: static_cast from 'void *' to
'MIDIEndpointRef' (aka 'unsigned int') is not allowed
  MIDIEndpointRef source = static_cast<MIDIEndpointRef>(src_conn_refcon);
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Powered by Google App Engine
This is Rietveld 408576698