Issue 17288017: Disable scroll-bars in shrink-to-fit mode.

Issue 17288017: Disable scroll-bars in shrink-to-fit mode. (Closed)

Created:
7 years, 6 months ago by Jamie

Modified:
7 years, 6 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable scroll-bars in shrink-to-fit mode. This works around a bug in Chrome whereby scroll-bars are added unnecessarily. BUG=252796, 240772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207935

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -0 lines)			Patch
M	remoting/webapp/client_session.js	View	1 chunk	+8 lines, -0 lines	2 comments	Download
M	remoting/webapp/main.css	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	remoting/webapp/ui_mode.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Wez

lgtm https://codereview.chromium.org/17288017/diff/1/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): https://codereview.chromium.org/17288017/diff/1/remoting/webapp/client_session.js#newcode659 remoting/webapp/client_session.js:659: document.body.parentNode.classList.add('no-scroll'); I assume that classList has set behaviour, ...

7 years, 6 months ago (2013-06-21 19:01:05 UTC) #2

Jamie

fyi https://codereview.chromium.org/17288017/diff/1/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): https://codereview.chromium.org/17288017/diff/1/remoting/webapp/client_session.js#newcode659 remoting/webapp/client_session.js:659: document.body.parentNode.classList.add('no-scroll'); On 2013/06/21 19:01:05, Wez wrote: > I ...

7 years, 6 months ago (2013-06-21 19:21:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/17288017/1

7 years, 6 months ago (2013-06-21 19:24:04 UTC) #4

Message was sent while issue was closed.

Change committed as 207935

Expand Messages | Collapse Messages