Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: runtime/dart-runtime.gyp

Issue 17288009: Removes references to LIB_DIR from gyp files. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/bin.gypi ('k') | runtime/vm/vm.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/dart-runtime.gyp
===================================================================
--- runtime/dart-runtime.gyp (revision 24193)
+++ runtime/dart-runtime.gyp (working copy)
@@ -11,11 +11,7 @@
'third_party/jscre/jscre.gypi',
],
'variables': {
- # TODO(zra): LIB_DIR is not defined by the ninja generator on Windows.
- # Also, LIB_DIR is not toolset specific on Mac. If we want to do a ninja
- # build on Windows, or cross-compile on Mac, we'll have to find some other
- # way of getting generated source files into toolset specific locations.
- 'gen_source_dir': '<(LIB_DIR)',
+ 'gen_source_dir': '<(SHARED_INTERMEDIATE_DIR)',
'version_in_cc_file': 'vm/version_in.cc',
'version_cc_file': '<(gen_source_dir)/version.cc',
@@ -42,7 +38,7 @@
'libdart_vm',
'libjscre',
'libdouble_conversion',
- 'generate_version_cc_file',
+ 'generate_version_cc_file#host',
],
'include_dirs': [
'.',
@@ -72,7 +68,7 @@
{
'target_name': 'generate_version_cc_file',
'type': 'none',
- 'toolsets':['target','host'],
+ 'toolsets':['host'],
'dependencies': [
'libdart_dependency_helper.target#target',
'libdart_dependency_helper.host#host',
« no previous file with comments | « runtime/bin/bin.gypi ('k') | runtime/vm/vm.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698