Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 172873007: Move lists of source files used in remoting client to remoting_srcs.gypi (Closed)

Created:
6 years, 10 months ago by Sergey Ulanov
Modified:
6 years, 10 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Move lists of source files used in remoting client to remoting_srcs.gypi PNaCl plugin will need to share lists of sources with the existing targets. Moved these lists to remoting_srcs.gypy to avoid duplicating them. BUG=276739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -226 lines) Patch
M remoting/remoting.gyp View 3 chunks +3 lines, -176 lines 0 comments Download
M remoting/remoting_client.gypi View 2 chunks +2 lines, -50 lines 0 comments Download
A remoting/remoting_srcs.gypi View 1 chunk +245 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergey Ulanov
6 years, 10 months ago (2014-02-19 23:39:57 UTC) #1
garykac
lgtm
6 years, 10 months ago (2014-02-20 00:08:46 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-20 00:13:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/172873007/1
6 years, 10 months ago (2014-02-20 01:46:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/172873007/1
6 years, 10 months ago (2014-02-20 05:17:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/172873007/1
6 years, 10 months ago (2014-02-20 09:17:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/172873007/1
6 years, 10 months ago (2014-02-20 12:33:46 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 17:07:07 UTC) #8
Message was sent while issue was closed. 
Change committed as 252281

Powered by Google App Engine
This is Rietveld 408576698