Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1728713002: VM: Fix product build. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: make flags constant correctly in non-precompiled, product mode" Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flags.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index 9c37ed5c64d671f655508b03ed56b5043f77617c..d64690937963ea03d7a98e5bb2c0bd04ee100936 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -128,16 +128,22 @@ static void PrecompilationModeHandler(bool value) {
// while precompilation has only one.
FLAG_background_compilation = false;
FLAG_collect_dynamic_function_names = true;
-#if !defined(DART_PRECOMPILED_RUNTIME)
+#if !defined(DART_PRECOMPILED_RUNTIME) && !defined(PRODUCT)
FLAG_lazy_dispatchers = false;
FLAG_polymorphic_with_deopt = false;
// Precompilation finalizes all classes and thus allows CHA optimizations.
// Do not require CHA triggered deoptimization.
FLAG_use_cha_deopt = false;
-#else
+#elif defined(DART_PRECOMPILED_RUNTIME)
+ // Precompiled product and release mode.
COMPILE_ASSERT(!FLAG_lazy_dispatchers);
COMPILE_ASSERT(!FLAG_polymorphic_with_deopt);
COMPILE_ASSERT(!FLAG_use_cha_deopt);
+#elif defined(PRODUCT)
+ // Jit product and release mode.
+ COMPILE_ASSERT(FLAG_lazy_dispatchers);
+ COMPILE_ASSERT(FLAG_polymorphic_with_deopt);
+ COMPILE_ASSERT(FLAG_use_cha_deopt);
#endif
}
}
« no previous file with comments | « runtime/vm/flags.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698