runtime/vm/flags.h - Issue 1728713002: VM: Fix product build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flags.h

Issue 1728713002: VM: Fix product build. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: make flags constant correctly in non-precompiled, product mode" Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flags.h

diff --git a/runtime/vm/flags.h b/runtime/vm/flags.h

index 81e69c04d141e7972e38fe1ffe7872f5999dfd2b..81f594eb1f1e6d26fb3564207a10a29576dbe246 100644

--- a/runtime/vm/flags.h

+++ b/runtime/vm/flags.h

@@ -111,8 +111,7 @@ class Flags {

#endif // defined(DEBUG)

#if defined(PRODUCT) && defined(DART_PRECOMPILED_RUNTIME)

-#define RELEASE_FLAG_MARCO(name, precompiled_value, product_value, type, \

- default_value, comment) \

+#define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment) \

const type FLAG_##name = product_value;

#define PRECOMPILE_FLAG_MARCO(name, precompiled_value, product_value, type, \

default_value, comment) \

@@ -123,7 +122,7 @@ class Flags {

const type FLAG_##name = product_value;

#define PRECOMPILE_FLAG_MARCO(name, precompiled_value, product_value, type, \

default_value, comment) \

- extern type FLAG_##name;

+ const type FLAG_##name = product_value;

#elif defined(DART_PRECOMPILED_RUNTIME) // !PRODUCT

#define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment) \

« no previous file with comments | « no previous file | runtime/vm/flags.cc » ('j') | no next file with comments »