Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: runtime/vm/flags.cc

Issue 1728713002: VM: Fix product build. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: make flags constant correctly in non-precompiled, product mode" Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flags.h ('k') | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flags.h" 5 #include "vm/flags.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 #include "vm/json_stream.h" 8 #include "vm/json_stream.h"
9 #include "vm/os.h" 9 #include "vm/os.h"
10 10
(...skipping 22 matching lines...) Expand all
33 #if defined(PRODUCT) && defined(DART_PRECOMPILED_RUNTIME) 33 #if defined(PRODUCT) && defined(DART_PRECOMPILED_RUNTIME)
34 // Nothing to be done for the product flag definitions. 34 // Nothing to be done for the product flag definitions.
35 #define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment) 35 #define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment)
36 // Nothing to be done for the precompilation flag definitions. 36 // Nothing to be done for the precompilation flag definitions.
37 #define PRECOMPILE_FLAG_MARCO(name, pre_value, product_value, type, \ 37 #define PRECOMPILE_FLAG_MARCO(name, pre_value, product_value, type, \
38 default_value, comment) 38 default_value, comment)
39 39
40 #elif defined(PRODUCT) // !PRECOMPILED 40 #elif defined(PRODUCT) // !PRECOMPILED
41 // Nothing to be done for the product flag definitions. 41 // Nothing to be done for the product flag definitions.
42 #define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment) 42 #define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment)
43 // Nothing to be done for the precompilation flag definitions.
44 #define PRECOMPILE_FLAG_MARCO(name, pre_value, product_value, type, \
45 default_value, comment)
43 46
44 #elif defined(DART_PRECOMPILED_RUNTIME) // !PRODUCT 47 #elif defined(DART_PRECOMPILED_RUNTIME) // !PRODUCT
45 #define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment) \ 48 #define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment) \
46 type FLAG_##name = Flags::Register_##type(&FLAG_##name, \ 49 type FLAG_##name = Flags::Register_##type(&FLAG_##name, \
47 #name, \ 50 #name, \
48 default_value, \ 51 default_value, \
49 comment); 52 comment);
50 // Nothing to be done for the precompilation flag definitions. 53 // Nothing to be done for the precompilation flag definitions.
51 #define PRECOMPILE_FLAG_MARCO(name, pre_value, product_value, type, \ 54 #define PRECOMPILE_FLAG_MARCO(name, pre_value, product_value, type, \
52 default_value, comment) 55 default_value, comment)
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
533 } 536 }
534 JSONObject jsobj(js); 537 JSONObject jsobj(js);
535 jsobj.AddProperty("type", "FlagList"); 538 jsobj.AddProperty("type", "FlagList");
536 JSONArray jsarr(&jsobj, "flags"); 539 JSONArray jsarr(&jsobj, "flags");
537 for (intptr_t i = 0; i < num_flags_; ++i) { 540 for (intptr_t i = 0; i < num_flags_; ++i) {
538 PrintFlagToJSONArray(&jsarr, flags_[i]); 541 PrintFlagToJSONArray(&jsarr, flags_[i]);
539 } 542 }
540 } 543 }
541 544
542 } // namespace dart 545 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flags.h ('k') | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698