Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1728713002: VM: Fix product build. (Closed)

Created:
4 years, 10 months ago by Florian Schneider
Modified:
4 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : make flags constant correctly in non-precompiled, product mode" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M runtime/vm/flags.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flags.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
tbr
4 years, 10 months ago (2016-02-23 19:20:56 UTC) #1
Florian Schneider
ptal
4 years, 10 months ago (2016-02-23 20:48:05 UTC) #2
siva
lgtm
4 years, 10 months ago (2016-02-23 20:51:07 UTC) #3
Florian Schneider
4 years, 10 months ago (2016-02-23 20:54:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
843cbca42734dd721b1ddb85c25857da2bbbfa4f.

Powered by Google App Engine
This is Rietveld 408576698