Made the visibility of Buttom bar updated at the end of drag selection.

Made the visibility of Buttom bar updated at the end of drag selection.

At the end of dragselection, the dragend events are not published because the
default behavior of the dragstart events are prevented by DragSelector.

This CL added the dragselectionend event and made the visibility of Button bar
updated by handling the event.

BUG=251703
TEST=manually
R=yoshiki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207772

[hirono, 2013-06-19 13:18:52]

Could you check the CL?
Thank you very much!

[yoshiki, 2013-06-20 03:11:25]

https://codereview.chromium.org/17287004/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/drag_selector.js (right):

https://codereview.chromium.org/17287004/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/drag_selector.js:241:
this.target_.dispatchEvent(new Event('dragselectionend'));
Is it possible to use cr.dispatchSimpleEvent(this.target_, 'dragselectionend')
instead? It's common way in Files.app.

https://codereview.chromium.org/17287004/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/17287004/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:1168:
this.table_.list.addEventListener('dragselectionend', dragEndBound);
The grid should be handled as well, right?

[hirono, 2013-06-20 03:55:03]

Fixed. Thank you!

https://codereview.chromium.org/17287004/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/drag_selector.js (right):

https://codereview.chromium.org/17287004/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/drag_selector.js:241:
this.target_.dispatchEvent(new Event('dragselectionend'));
On 2013/06/20 03:11:25, yoshiki wrote:
> Is it possible to use cr.dispatchSimpleEvent(this.target_, 'dragselectionend')
> instead? It's common way in Files.app.

Done.

https://codereview.chromium.org/17287004/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/17287004/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:1168:
this.table_.list.addEventListener('dragselectionend', dragEndBound);
On 2013/06/20 03:11:25, yoshiki wrote:
> The grid should be handled as well, right?

It is not needed yet.
Currently the grid view does not support the drag selection.
I'm planning on supporting the drag selection on the grid view for M30,
and at that time, we should handle the dragselectionend event.

[yoshiki, 2013-06-20 10:53:42]

lgtm

[hirono, 2013-06-21 02:13:38]

On 2013/06/20 10:53:42, yoshiki wrote:
> lgtm

Thanks!

[commit-bot: I haz the power, 2013-06-21 02:13:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/17287004/5001

[hirono, 2013-06-21 09:50:18]

Committed patchset #2 manually as r207772 (presubmit successful).