Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: tests/corelib/corelib.status

Issue 1728663002: Skip tests which use dart:mirrors in product mode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code-review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/corelib/corelib.status
diff --git a/tests/corelib/corelib.status b/tests/corelib/corelib.status
index 3d4c8490a95cfac09684b6bfb630c4d55c3bc04c..5b53345c7423089b551662393bb830aeb7f7fac8 100644
--- a/tests/corelib/corelib.status
+++ b/tests/corelib/corelib.status
@@ -194,3 +194,4 @@ int_parse_radix_test: Pass, Timeout # --no_intrinsify
[ ($runtime == dart_product) ]
data_resource_test: Skip # Resolve URI not supported yet in product mode.
package_resource_test: Skip # Resolve URI not supported yet in product mode.
+apply3_test: CompileTimeError # Imports dart:mirrors
Ivan Posva 2016/02/25 01:50:18 Why is this test not skipped? And would the other
siva 2016/02/25 02:08:41 Done.

Powered by Google App Engine
This is Rietveld 408576698