runtime/vm/object.cc - Issue 1728663002: Skip tests which use dart:mirrors in product mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 1728663002: Skip tests which use dart:mirrors in product mode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: add-one-more-test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index aea7d1f6e31e48b7f8a15d8863559c72508260a0..e79fb9da5f3099ad6a696f4ac9e527e872aa608a 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -1924,7 +1924,7 @@ RawString* Class::PrettyName() const {

RawString* Class::UserVisibleName() const {

#if defined(PRODUCT)

- return raw_ptr()->name_;

+ return GenerateUserVisibleName();

Ivan Posva 2016/02/23 18:34:59 Any particular reason why you disable shaking of t

siva 2016/02/23 19:06:42 The following construct obj.runtimeType.toString()

#else // defined(PRODUCT)

ASSERT(raw_ptr()->user_name_ != String::null());

return raw_ptr()->user_name_;

« no previous file with comments | « runtime/tests/vm/vm.status ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »