Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1728663002: Skip tests which use dart:mirrors in product mode (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Skip tests which use dart:mirrors in product mode Committed: https://github.com/dart-lang/sdk/commit/5c53e14d55fcd244daea369d85988d7aae36bed3

Patch Set 1 #

Patch Set 2 : add-one-more-test #

Total comments: 2

Patch Set 3 : code-review #

Total comments: 6

Patch Set 4 : code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
siva
4 years, 10 months ago (2016-02-23 17:44:29 UTC) #2
siva
4 years, 10 months ago (2016-02-23 17:57:51 UTC) #3
Ivan Posva
https://codereview.chromium.org/1728663002/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1728663002/diff/20001/runtime/vm/object.cc#newcode1927 runtime/vm/object.cc:1927: return GenerateUserVisibleName(); Any particular reason why you disable shaking ...
4 years, 10 months ago (2016-02-23 18:34:59 UTC) #5
siva
https://codereview.chromium.org/1728663002/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1728663002/diff/20001/runtime/vm/object.cc#newcode1927 runtime/vm/object.cc:1927: return GenerateUserVisibleName(); On 2016/02/23 18:34:59, Ivan Posva wrote: > ...
4 years, 10 months ago (2016-02-23 19:06:42 UTC) #6
siva
4 years, 10 months ago (2016-02-25 01:47:06 UTC) #8
Ivan Posva
LGTMwC -ip https://codereview.chromium.org/1728663002/diff/40001/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/1728663002/diff/40001/runtime/tests/vm/vm.status#newcode90 runtime/tests/vm/vm.status:90: dart/redirection_type_shuffling_test: Skip # Imports dart:mirrors SkipByDesign so ...
4 years, 10 months ago (2016-02-25 01:50:18 UTC) #9
siva
https://codereview.chromium.org/1728663002/diff/40001/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/1728663002/diff/40001/runtime/tests/vm/vm.status#newcode90 runtime/tests/vm/vm.status:90: dart/redirection_type_shuffling_test: Skip # Imports dart:mirrors On 2016/02/25 01:50:18, Ivan ...
4 years, 10 months ago (2016-02-25 02:08:41 UTC) #10
siva
4 years, 10 months ago (2016-02-25 02:13:24 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
5c53e14d55fcd244daea369d85988d7aae36bed3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698