Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1728603002: Fix ui::Event::Clone() for ui::PointerEvent. (Closed)

Created:
4 years, 10 months ago by Hadi
Modified:
4 years, 10 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ui::Event::Clone() for ui::PointerEvent. We need this to work correctly to be able to use pointer events in mus event dispatcher. BUG=584859 Committed: https://crrev.com/aa58e608bab892bd96e9e6c11b8c4777cb3e6834 Cr-Commit-Position: refs/heads/master@{#377066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M ui/events/event.h View 4 chunks +8 lines, -1 line 0 comments Download
M ui/events/event.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M ui/events/event_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Hadi
PTAL.
4 years, 10 months ago (2016-02-23 16:08:01 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-02-23 17:38:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728603002/1
4 years, 10 months ago (2016-02-23 18:20:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 19:49:47 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 19:51:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa58e608bab892bd96e9e6c11b8c4777cb3e6834
Cr-Commit-Position: refs/heads/master@{#377066}

Powered by Google App Engine
This is Rietveld 408576698