Adds a first-run balloon to the Windows notification center.

chrome/browser/notifications/message_center_notifications_unittest.cc

Index: chrome/browser/notifications/message_center_notifications_unittest.cc
diff --git a/chrome/browser/notifications/message_center_notifications_unittest.cc b/chrome/browser/notifications/message_center_notifications_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..140f85f6a588f264db3797d6c2ab4ca79b7df4ee
--- /dev/null
+++ b/chrome/browser/notifications/message_center_notifications_unittest.cc
@@ -0,0 +1,172 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/scoped_ptr.h"
+#include "base/prefs/testing_pref_service.h"
+#include "base/run_loop.h"
+#include "base/test/test_timeouts.h"
+#include "base/values.h"
+#include "chrome/browser/notifications/message_center_notification_manager.h"
+#include "chrome/browser/notifications/notification.h"
+#include "chrome/browser/notifications/notification_prefs_manager.h"
+#include "chrome/browser/notifications/notification_test_util.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/scoped_testing_local_state.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/message_center/message_center_impl.h"
+#include "ui/message_center/message_center_tray.h"
+#include "ui/message_center/message_center_tray_delegate.h"
+
+namespace message_center {
+class FakeMessageCenterTrayDelegate : public MessageCenterTrayDelegate {
+ public:
+  FakeMessageCenterTrayDelegate(MessageCenter* message_center,
+                                base::Closure quit_closure)
+      : tray_(this, message_center),
+        quit_closure_(quit_closure),
+        displayed_first_run_balloon_(false) {}
+
+  virtual void DisplayFirstRunBalloon() OVERRIDE {
+    displayed_first_run_balloon_ = true;
+    base::MessageLoop::current()->PostTask(FROM_HERE, quit_closure_);
+  }
+
+  virtual void OnMessageCenterTrayChanged() OVERRIDE {}
+  virtual bool ShowPopups() OVERRIDE { return true; }
+  virtual void HidePopups() OVERRIDE {}
+  virtual void UpdatePopups() OVERRIDE {}
+  virtual bool ShowMessageCenter() OVERRIDE { return true; }
+  virtual bool ShowNotifierSettings() OVERRIDE { return true; }
+  virtual void HideMessageCenter() OVERRIDE {}
+
+  bool displayed_first_run_balloon() const {
+    return displayed_first_run_balloon_;
+  }
+ private:
+  MessageCenterTray tray_;
+  base::Closure quit_closure_;
+  bool displayed_first_run_balloon_;
+};
+
+class MessageCenterNotificationManagerTest : public testing::Test {
+ protected:
+  MessageCenterNotificationManagerTest() {
+    NotificationPrefsManager::RegisterPrefs(local_state_.registry());
+  }
+
+  virtual void SetUp() {
+    // Clear the preference and initialize.
+    local_state_.ClearPref(prefs::kMessageCenterShowedFirstRunBalloon);
+    first_run_pref_.Init(prefs::kMessageCenterShowedFirstRunBalloon,
+                         &local_state_);
+
+    // Get ourselves a run loop.
+    run_loop_.reset(new base::RunLoop());
+
+    // Initialize message center infrastructure with mock tray delegate.
+    MessageCenter::Initialize();
+    message_center_ = MessageCenter::Get();
+    notification_manager_.reset(
+        new MessageCenterNotificationManager(message_center_, &local_state_));
+    delegate_ = new FakeMessageCenterTrayDelegate(message_center_,
+                                                  run_loop_->QuitClosure());
+    notification_manager_->SetMessageCenterTrayDelegateForTest(delegate_);
+    notification_manager_->SetFirstRunTimeoutForTest(
+        TestTimeouts::tiny_timeout());
+  }
+
+  virtual void TearDown() {
+    run_loop_.reset();
+    notification_manager_.reset();
+    MessageCenter::Shutdown();
+  }
+
+  MessageCenterNotificationManager* notification_manager() {
+    return notification_manager_.get();
+  }
+
+  FakeMessageCenterTrayDelegate* delegate() { return delegate_; }
+
+  MessageCenter* message_center() { return message_center_; }
+
+  const ::Notification GetANotification(const std::string& id) {

[Dmitry Titov, 2013/06/21 20:53:40]

Get->Create?

can also return a const ref, for the sake of consistency with other code...

[dewittj, 2013/06/21 21:56:51]

Actually it can't since that would return a reference to a stack frame that no
longer exists.

+    return ::Notification(GURL(),
+                          GURL(),
+                          string16(),
+                          string16(),
+                          new MockNotificationDelegate(id));
+  }
+
+  base::RunLoop* run_loop() { return run_loop_.get(); }
+  const TestingPrefServiceSimple& local_state() { return local_state_; }
+  bool DidFirstRunPref() { return first_run_pref_.GetValue(); }
+
+ private:
+  scoped_ptr<base::RunLoop> run_loop_;
+  TestingPrefServiceSimple local_state_;
+  MessageCenter* message_center_;
+  scoped_ptr<MessageCenterNotificationManager> notification_manager_;
+  FakeMessageCenterTrayDelegate* delegate_;
+  content::TestBrowserThreadBundle thread_bundle_;
+  BooleanPrefMember first_run_pref_;
+};
+
+#if !defined(OS_CHROMEOS)
+TEST_F(MessageCenterNotificationManagerTest, SetupNotificationManager) {
+  TestingProfile profile;
+  notification_manager()->Add(GetANotification("test"), &profile);
+  EXPECT_FALSE(DidFirstRunPref());
+}
+#endif
+
+#if defined(OS_WIN)
+// The following tests test the first run balloon, which is only implemented for
+// Windows.
+TEST_F(MessageCenterNotificationManagerTest, FirstRunShown) {
+  TestingProfile profile;
+  notification_manager()->Add(GetANotification("test"), &profile);
+  message_center()->DisplayedNotification("test");
+  message_center()->MarkSinglePopupAsShown("test", false);
+
+  run_loop()->Run();
+  base::RunLoop run_loop_2;
+  run_loop_2.RunUntilIdle();
+  EXPECT_TRUE(delegate()->displayed_first_run_balloon());
+  EXPECT_TRUE(DidFirstRunPref());
+}
+
+TEST_F(MessageCenterNotificationManagerTest,
+       FirstRunNotShownWithPopupsVisible) {
+  TestingProfile profile;
+  notification_manager()->Add(GetANotification("test"), &profile);
+  message_center()->DisplayedNotification("test");
+
+  base::MessageLoop::current()->PostDelayedTask(
+      FROM_HERE,
+      run_loop()->QuitClosure(),
+      TestTimeouts::tiny_timeout() + base::TimeDelta::FromMilliseconds(10));

[Dmitry Titov, 2013/06/21 20:53:40]

tests based on timeouts are not welcome in Chrome. Especially if the ode in
question also is implemented using timeout. Is it possible to make it more
deterministic? Can be a separate CL.

[dewittj, 2013/06/21 21:56:51]

Done.

+  run_loop()->Run();
+  EXPECT_FALSE(delegate()->displayed_first_run_balloon());
+  EXPECT_FALSE(DidFirstRunPref());
+}
+
+TEST_F(MessageCenterNotificationManagerTest,
+       FirstRunNotShownWithMessageCenter) {
+  TestingProfile profile;
+  notification_manager()->Add(GetANotification("test"), &profile);
+  message_center()->SetMessageCenterVisible(true);
+
+  base::MessageLoop::current()->PostDelayedTask(
+      FROM_HERE,
+      run_loop()->QuitClosure(),
+      TestTimeouts::tiny_timeout() + base::TimeDelta::FromMilliseconds(10));
+  run_loop()->Run();
+  EXPECT_FALSE(delegate()->displayed_first_run_balloon());
+  EXPECT_FALSE(DidFirstRunPref());
+}
+#endif  // defined(OS_WIN)
+}  // namespace message_center