Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/ui/views/status_icons/status_tray_win.h" | 5 #include "chrome/browser/ui/views/status_icons/status_tray_win.h" |
| 6 | 6 |
| 7 #include "base/strings/string_util.h" | 7 #include "base/strings/string_util.h" |
| 8 #include "base/strings/utf_string_conversions.h" | 8 #include "base/strings/utf_string_conversions.h" |
| 9 #include "chrome/browser/status_icons/status_icon_observer.h" | 9 #include "chrome/browser/status_icons/status_icon_observer.h" |
| 10 #include "chrome/browser/ui/views/status_icons/status_icon_win.h" | 10 #include "chrome/browser/ui/views/status_icons/status_icon_win.h" |
| 11 #include "grit/chrome_unscaled_resources.h" | 11 #include "grit/chrome_unscaled_resources.h" |
| 12 #include "testing/gmock/include/gmock/gmock.h" | |
| 13 #include "testing/gtest/include/gtest/gtest.h" | 12 #include "testing/gtest/include/gtest/gtest.h" |
| 14 #include "ui/base/models/simple_menu_model.h" | 13 #include "ui/base/models/simple_menu_model.h" |
| 15 #include "ui/base/resource/resource_bundle.h" | 14 #include "ui/base/resource/resource_bundle.h" |
| 16 | 15 |
| 17 class SkBitmap; | 16 class FakeStatusIconObserver : public StatusIconObserver { |
| 17 public: | |
| 18 FakeStatusIconObserver() | |
| 19 : balloon_clicked_(false), | |
| 20 status_icon_click_count_(0) {} | |
| 21 virtual void OnStatusIconClicked() { | |
| 22 ++status_icon_click_count_; | |
| 23 } | |
| 24 virtual void OnBalloonClicked() { balloon_clicked_ = true; } | |
| 25 bool balloon_clicked() const { return balloon_clicked_; } | |
| 26 size_t status_icon_click_count() const { | |
| 27 return status_icon_click_count_; | |
| 28 } | |
| 18 | 29 |
| 19 class MockStatusIconObserver : public StatusIconObserver { | 30 private: |
| 20 public: | 31 size_t status_icon_click_count_; |
| 21 MOCK_METHOD0(OnStatusIconClicked, void()); | 32 bool balloon_clicked_; |
| 22 }; | 33 }; |
| 23 | 34 |
| 24 TEST(StatusTrayWinTest, CreateTray) { | 35 TEST(StatusTrayWinTest, CreateTray) { |
| 25 // Just tests creation/destruction. | 36 // Just tests creation/destruction. |
| 26 StatusTrayWin tray; | 37 StatusTrayWin tray; |
| 27 } | 38 } |
| 28 | 39 |
| 29 TEST(StatusTrayWinTest, CreateIconAndMenu) { | 40 TEST(StatusTrayWinTest, CreateIconAndMenu) { |
| 30 // Create an icon, set the images, tooltip, and context menu, then shut it | 41 // Create an icon, set the images, tooltip, and context menu, then shut it |
| 31 // down. | 42 // down. |
| 32 StatusTrayWin tray; | 43 StatusTrayWin tray; |
| 33 StatusIcon* icon = tray.CreateStatusIcon(); | 44 StatusIcon* icon = tray.CreateStatusIcon(); |
| 34 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); | 45 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); |
| 35 gfx::ImageSkia* image = rb.GetImageSkiaNamed(IDR_STATUS_TRAY_ICON); | 46 gfx::ImageSkia* image = rb.GetImageSkiaNamed(IDR_STATUS_TRAY_ICON); |
| 36 icon->SetImage(*image); | 47 icon->SetImage(*image); |
| 37 icon->SetPressedImage(*image); | 48 icon->SetPressedImage(*image); |
| 38 icon->SetToolTip(ASCIIToUTF16("tool tip")); | 49 icon->SetToolTip(ASCIIToUTF16("tool tip")); |
| 39 ui::SimpleMenuModel* menu = new ui::SimpleMenuModel(NULL); | 50 ui::SimpleMenuModel* menu = new ui::SimpleMenuModel(NULL); |
| 40 menu->AddItem(0, L"foo"); | 51 menu->AddItem(0, L"foo"); |
| 41 icon->SetContextMenu(menu); | 52 icon->SetContextMenu(menu); |
| 42 } | 53 } |
| 43 | 54 |
| 44 #if !defined(USE_AURA) // http://crbug.com/156370 | 55 #if !defined(USE_AURA) // http://crbug.com/156370 |
| 45 TEST(StatusTrayWinTest, ClickOnIcon) { | 56 TEST(StatusTrayWinTest, ClickOnIcon) { |
| 46 // Create an icon, send a fake click event, make sure observer is called. | 57 // Create an icon, send a fake click event, make sure observer is called. |
| 47 StatusTrayWin tray; | 58 StatusTrayWin tray; |
| 48 StatusIconWin* icon = static_cast<StatusIconWin*>(tray.CreateStatusIcon()); | 59 StatusIconWin* icon = static_cast<StatusIconWin*>(tray.CreateStatusIcon()); |
| 49 MockStatusIconObserver observer; | 60 FakeStatusIconObserver observer; |
| 50 icon->AddObserver(&observer); | 61 icon->AddObserver(&observer); |
| 51 EXPECT_CALL(observer, OnStatusIconClicked()); | |
| 52 // Mimic a click. | 62 // Mimic a click. |
| 53 tray.WndProc(NULL, icon->message_id(), icon->icon_id(), WM_LBUTTONDOWN); | 63 tray.WndProc(NULL, icon->message_id(), icon->icon_id(), WM_LBUTTONDOWN); |
| 54 // Mimic a right-click - observer should not be called. | 64 // Mimic a right-click - observer should not be called. |
| 55 tray.WndProc(NULL, icon->message_id(), icon->icon_id(), WM_RBUTTONDOWN); | 65 tray.WndProc(NULL, icon->message_id(), icon->icon_id(), WM_RBUTTONDOWN); |
| 66 EXPECT_EQ(1, observer.status_icon_click_count()); | |
| 67 icon->RemoveObserver(&observer); | |
| 68 } | |
| 69 | |
| 70 TEST(StatusTrayWinTest, ClickOnBalloon) { | |
| 71 // Create an icon, send a fake click event, make sure observer is called. | |
| 72 StatusTrayWin tray; | |
| 73 StatusIconWin* icon = static_cast<StatusIconWin*>(tray.CreateStatusIcon()); | |
| 74 FakeStatusIconObserver observer; | |
| 75 icon->AddObserver(&observer); | |
| 76 // Mimic a click. | |
| 77 tray.WndProc(NULL, icon->message_id(), icon->icon_id(), WM_USER + 5); | |
|
Andrew T Wilson (Slow)
2013/06/20 21:08:59
The WM_USER + 5 seems a bit kludgey here. Is there
dewittj
2013/06/21 20:35:15
Done. Unfortunately TB_INDETERMINATE doesn't seem
| |
| 78 EXPECT_TRUE(observer.balloon_clicked()); | |
| 56 icon->RemoveObserver(&observer); | 79 icon->RemoveObserver(&observer); |
| 57 } | 80 } |
| 58 #endif // !defined(USE_AURA) | 81 #endif // !defined(USE_AURA) |
| OLD | NEW |